resolve multigraph issue with value unpacking #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure whether GitHub would have notified you of this, but I opened and accepted an instance of this pull request in my fork (which was originally made precisely to have a version with fixes from issues and PRs). The fork has now been detached and released as its own library, altair-nx, because the original has been inactive since 2020 and because the fork diverged from it considerably after a full code-base rework and the implementation of new features (e.g. curved edges, self loops, and much greater customisability). |
|
@T-Flet Ah thanks for the @. I indeed had not gotten a notification from GitHub. Great work! I'm glad you've separated it out and continued to improve its flexibility! I'll look more into altair-nx later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #13
Currently, when trying to convert a networkx multigraph, a ValueError is thrown. This is caused by to_pandas_edges, where the edge keys are added to the attributes.
This PR simply checks if the graph is a multigraph, and if so, skips this step.